Submission Details
Severity:
Missing multiplication to generationDeviationFactor in `finalizeValidation`
Summary
This error is just my guess, that the code lacks multiplication, I can be wrong, so I put severity = low.
In the finalityValidation function, stddev is subtracted from mean. Here are two examples of code.
first
for (uint256 v_i = 0; v_i < task.parameters.numValidations; ++v_i) {
uint256 score = scores[v_i];
if ((score >= _mean - _stddev) && (score <= _mean + _stddev)) {
innerSum += score;
innerCount++;
// send validation fee to the validator
_increaseAllowance(validations[taskId][v_i].validator, task.validatorFee);
}
}
second
for (uint256 g_i = 0; g_i < task.parameters.numGenerations; g_i++) {
// ignore lower outliers
if (generationScores[g_i] >= mean - generationDeviationFactor * stddev) {
_increaseAllowance(responses[taskId][g_i].responder, task.generatorFee);
}
}
as we see, in the second example stddev is multiplied by generationDeviationFactor.
However, the protocol also has a validationDeviationFactor variable that is only initialized and not used anywhere.
Suppose that it should have been in the first case.
If it is not, then this variable is dead code and can be deleted.
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420 USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.