Dria

Summary

In the current implementation of Swan::createBuyer, the underlying logic creates buyer using the assigned BuyerFactory. The problem is that during list and reslit, the protocol doesn't check whether this buyer is created by the given factory.

Impact

Without restricting buyers to those created by the factory, unauthorised or external buyers could exploit the system by bypassing checks or validations enforced by the protocol’s BuyerFactory. This opens up the potential for malicious actions that could affect system stability or security.

Tools Used

Manual Review

Recommendations

Introduce Validation Checks: Modify Swan::list and Swan::relist to verify that buyers were instantiated via the protocol’s BuyerFactory.