Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: medium
Valid

Generator and Validator could be one user transferring the fees over and over

Summary

The current system allows users to assume the roles of both Generator and Validator by depositing a fee. However, users can exploit this by switching between these roles or creating multiple validations for a single task through different addresses. This poses a risk to the integrity of the validation process.

Vulnerability Details

In the current implementation, users can register as either a generator or validator immediately upon depositing a fee, as shown in the register(). Conversely, they can unregister and receive their deposit back at any time, as seen in the unregister() function.

Because there is no delay or restriction when unregistering, users can quickly switch between roles, undermining the validation process by acting as both generator and validator. This process allows a single user to create and validate tasks without sufficient checks, potentially leading to biased or unreliable validations.

Impact

This setup enables a single user to generate and validate all tasks, compromising the reliability of the validation process and potentially leading to biased, unraliable outcomes.

Tools Used

Manual review

Recommendations

Introduce a Delay: Require users to wait a defined duration (e.g., one round) before unregistering or switching roles. This would prevent immediate role changes and make it harder for a single user to assume both roles rapidly.

Role Delegation: Implement a role delegation system where an entity or governance body is responsible for assigning generator and validator roles. This would add a layer of oversight, ensuring that the roles are distributed to distinct participants.

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Known issue

Appeal created

auditism Submitter
12 months ago
inallhonesty Lead Judge
12 months ago
inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

There is no oracle whitelisting

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.