Dria

Summary

In the list function of the Swan.sol contract, there exists a vulnerability related to the enforcement of the maximum asset count allowed per buyer in a given round. The current implementation checks whether the count of assets for a buyer in a round is equal to maxAssetCount, allowing an additional asset to be listed when the count exceeds the limit. This oversight can lead to the unintentional listing of more assets than permitted, creating potential financial discrepancies and exploit opportunities

Vulnerability Details

Code Snippet of Concern:

The current condition only reverts the transaction when the count of assets for the buyer in the specified round is exactly equal to maxAssetCount. This allows the function to continue and list another asset if the count has already exceeded maxAssetCount, which is contrary to the intended logic expressed in the comment.

Impact

1. Violation of Asset Limits: The existing logic allows users to exceed the maximum asset count, potentially leading to an unregulated market environment.

2. User Confusion: Buyers might unintentionally create excess listings, resulting in confusion regarding the state of their assets and adherence to market rules.

3. Reputation Risk: If the protocol does not enforce expected limits, it may undermine user trust and confidence in the platform’s reliability.

Tools Used

Manual review

Recommendations

Modify the Condition: The conditional check in the list function should be updated to ensure that the count of assets for the buyer in the current round does not exceed maxAssetCount. The revised condition should look like this:

By implementing this change, the contract will correctly enforce the maximum asset count limit for each buyer in a round, preventing any unintended listings and maintaining the integrity of the asset management system.