Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: low
Invalid

`SwanManager::setOracleParameters` input is not validated and potentially makes DoS on `request` function

Summary

When setting new oracle parameters, the input is not validated and can cause DoS if the range is out of range described in LLMOracleManager minimumParameters and maximumParameters

Vulnerability Details

SwanManager.sol#L89-L91

function setOracleParameters(LLMOracleTaskParameters calldata _oracleParameters) external onlyOwner {
@> oracleParameters = _oracleParameters;
}

this input validation is crucial because modifier onlyValidParameters is checked and would be reverted any function using the modifier.

Impact

DoS crucial function LLMOracleCoordinator::request

Tools Used

manual review

Recommendations

make a safety check so the input of setOracleParameters is not under/above parameters set in LLMOracleManager

Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.