Dria

Summary

The list function in the Swan contract allows users to create new assets. However, there is a critical issue regarding the lack of validation to ensure that asset names and symbols are unique across the platform. This oversight may lead to multiple assets being created with identical names and symbols, resulting in confusion and potential misuse.

Vulnerability Detail

When a user attempts to create a new asset, the contract does not check whether an asset with the same name or symbol already exists in the system. This lack of a uniqueness check can have significant consequences:

• Users may inadvertently create assets that are indistinguishable from others, leading to a fragmented marketplace where assets with the same identifiers exist.

• Buyers and sellers may find it challenging to identify specific assets, which could reduce trust and engagement in the platform.

• The economic model may suffer, as duplicate assets could distort market dynamics and undermine the intended royalty structures.

Impact

The creation of assets with duplicate names and symbols poses several risks:

• Market Confusion: Users may struggle to differentiate between assets, potentially leading to disputes and dissatisfaction.

• Economic Implications: The presence of duplicate assets can lead to inconsistencies in royalty calculations and asset valuation.

• Brand Reputation: The platform’s credibility may be jeopardized if users perceive it as poorly managed or unreliable.

Tool used

Manual Code Review

Recommendation

To prevent duplicate asset creation, it is recommended to implement a mapping that tracks existing asset contracts by their names and symbols. Before allowing the creation of a new asset, the contract should check this mapping to ensure that the proposed name and symbol are unique. If a conflict is detected, the transaction should revert with an appropriate error message. This validation step would enhance the integrity of the asset marketplace and foster user confidence.