Submission Details
Severity:
The parameters are incorrect when revert BuyLimitExceeded
Summary
The parameters are incorrect when call revert BuyLimitExceeded
Vulnerability Details
In function purchase()of contract BuyerAgent.sol, it will call revert BuyLimitExceededwhen the spender is exceed than the limit of this round.
But it use the wrong paramter.
/// @notice Asset count limit exceeded for this round
error BuyLimitExceeded(uint256 have, uint256 want);
The first parameter is have should be amountPerRound and the second parameter is want should be spendings[round].
But actually the code of purchase is below.
revert BuyLimitExceeded(spendings[round], amountPerRound);`
Impact
This issue will provide wrong information to the owner of buyer agent.
Tools Used
mannul review
Recommendations
revert BuyLimitExceeded(amountPerRound, spendings[round]);
Updates
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420
USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.