Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: low
Invalid

transfer ERC20 token may failed due to using transferFrom instead of safeTransferFrom

Summary

The whole project use transferFrom or transfer to send ERC20 token, but some ERC20 token will return false rather than revert when transfer failed.

Vulnerability Details

for example in function purchase, if token return false rather than revert when transfer failed, listing.sellerwill not receive listing,price

// transfer money
token.transferFrom(listing.buyer, address(this), listing.price);
token.transfer(listing.seller, listing.price);

Impact

may causing loss fund

Tools Used

mannul review

Recommendations

use safeTransferFrom

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

[KNOWN] - Low-35 Unsafe use of transfer()/transferFrom() with IERC20

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.