Dria
Swan
NFTHardhat
21,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Valid

Sellers can list an asset at a price of zero

merlin

Summary

The seller sets the price for the NFT when calling the list or relist functions, and these functions do not have validation for a minimum value.

Vulnerability Details

A malicious seller can call the list function with a zero price until assetsPerBuyerRound.length reaches maxAssetCount. Essentially, all assets for that round will be zero-priced NFTs from the seller.

// asset count must not exceed `maxAssetCount`
if (getCurrentMarketParameters().maxAssetCount == assetsPerBuyerRound[_buyer][round].length) {
revert AssetLimitExceeded(getCurrentMarketParameters().maxAssetCount);
}

Impact

A malicious seller can conduct a DOS on the buyer during each round of the Buy phase by listing zero-priced NFTs, thereby avoiding paying royalties to both the buyer and the owner of Swan.sol.

Tools Used

Manual review

Recommendations

Consider implementing a minimum price validation for the list and relist functions.

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

DOS the buyer / Lack of minimal amount of listing price

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.