Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: low
Invalid
  1. If there are insufficient nodes (possibly due to requiring too many) or the difficulty requirements are too high, the buyer may not receive the oracle results during the buy phase.

  2. The validationDeviationFactor is an unused parameter.

  3. The marketParams array keeps growing, and if its length exceeds around 6,000, the gas required for a single transaction will surpass the gas limit, causing the getRoundPhase function to fail. This would render almost all of the agent's functionalities unusable.

  4. The isOperator does not need to include the swan address, as swan will not proactively call any privileged functions of the agent.

  5. There's no need to transfer SwanAsset and tokens to swan first before giving them to the user. Using transferFrom to directly send them to the user would be more gas-efficient.

  6. When the user calls the purchase function, if the number of assets bought in a single transaction exceeds around 39, the transaction will fail due to insufficient gas. Both the seller and the buyer will lose the transaction fees they have already paid.

Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.