Submission Details
Severity:
Potential DOS in purchase()
Summary
Potential DOS in purchase()
Vulnerability Details
In the purchase() :
https://github.com/Cyfrin/2024-10-swan-dria/blob/main/contracts/swan/BuyerAgent.sol#L222
// transfer asset from seller to Swan, and then from Swan to buyer
// this ensure that only approval to Swan is enough for the sellers
SwanAsset(_asset).transferFrom(listing.seller, address(this), 1);
SwanAsset(_asset).transferFrom(address(this), listing.buyer, 1);
Transfer asset from seller to Swan, and then transfer asset from Swan to buyer.
Impact
If the seller transfers the token to another address before the purchase() , the buyer will be unable to complete the purchase.
Tools Used
Recommendations
Updates
Lead Judging Commences
inallhonesty 12 months ago
Submission Judgement Published Assigned finding tags:
DoS in BuyerAgent::purchase
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420 USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.