Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: low
Invalid

Ownable should be used instead of `OwnableUpgradeable`

Summary

[`swanManager`](https://github.com/Cyfrin/2024-10-swan-dria/blob/c8686b199daadcef3161980022e12b66a5304f8e/contracts/swan/SwanManager.sol#L30) is not an upgradeable contract therefore there is no need to use the OwnableUpgradeable but use ownable instead.

Vulnerability Details

This is not the same as the issue found in the lightChaserV3 findings as the lightChaserV3 suggests that ownable_init has to be called in an initialise function.

But looking at this, it does not inherit the UUPS contract meaning it does not have the upgrading functionality so there is no need for the ownableUpgradeable. But instead Ownable has to be used just similar to `BuyerAgent`

Impact

Broken Owner functionality

Tools Used

Manual review

Recommendations

Use Ownable instead of OwnableUpgradeable.

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.