Submission Details
Severity:
Some tokens may revert when zero value transfers are made
Summary
BuyerAgent.sol::withdraw function does not check if _amount is zero before attempting a token transfer some ERC-20 tokens may revert when a zero-value transfer is attempted using the transfer function. This can lead to a revert in the withdraw function
Vulnerability Details
// transfer the tokens to the owner of Buyer
swan.token().transfer(owner(), _amount); // Zero-value transfer may revert
Impact
if _amount is zero the transfer may revert for certain(Swan) tokens, causing a Denial of Service (DoS) and as buyerAgent will not be able to complete withdrawals
Tools Used
Manual code review
Recommendations
// Check to prevent zero-value transfers
if (_amount > 0) {
// Ensure the transfer is successful
bool success = swan.token().transfer(owner(), _amount);
require(success, "Token transfer failed");
}
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420 USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.