Submission Details
Severity:
Transferring Asset and tokens can be done as one single Transfer
Description
When purchasing assets, they get transferred to the buyer, and the price if getting transferred to the seller
function purchase(address _asset) external {
...
>> SwanAsset(_asset).transferFrom(listing.seller, address(this), 1);
SwanAsset(_asset).transferFrom(address(this), listing.buyer, 1);
// transfer money
>> token.transferFrom(listing.buyer, address(this), listing.price);
token.transfer(listing.seller, listing.price);
...
}
There is no need to transfer to address(this) and then to the recipient, transferFrom can be used to transfer directly to the recipient, making it a one-step process instead of 2 step process.
Recommendations
use transferFrom the owner to the recipient directly, instead of transferring to address(this) and then transferring the asset to the recipient.
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420 USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.