Dria

Swan
NFTHardhat
21,000 USDC
Ended
View results
Submission Details
Severity: low
Invalid

No event emitting on changing critical variables

Description

Changing Critical variables that manage how a protocol works is important, especially in a protocol that relies heavily on off-chain things. The problem is that there are many functions that change critical variables in the protocol and do not emit any event representing the change.

  • SwanManager::setMarketParameters() -> Changes market parameters including intervals, fees, ,maximum assets per count

  • Swanmanager::oracleParameters() -> Changes the difficulty and num of registrations for Generation and calidation

  • SwanManager::setFactories() -> Changes The factories used for deploying BuyerAgents and SwanAssets

  • SwanManager::addOperator/removeOperator() -> add new Operators that can automate changing state process and purchasing on behalf BuyerAgent

  • BuyerAgent::setFeeRoyalty() -> BuyerAgent changes the fees he take (not that much important)

  • BuyerAgent::setAmountPerRound() -> Changes the maximum amount per Rounds a Buyer can pay for assets he buy (not that much important)

  • LLMOracleRegistry::setStakeAmounts() -> changes the amount should be paid by generators or validators

  • LLMOracleManager::setFees() -> changes fees (platform, generator and validator fees)

  • LLMOracleManager::setParameters()

  • LLMOracleManager::setDeviationFactors()

Recommendations

Add the suitable Events for all critical changing functions

Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Known issue

LightChaser, Low-34

Support

FAQs

Can’t find an answer? Join our Discord or follow us on Twitter.

Cyfrin
Updraft
CodeHawks
Solodit
Resources