Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: medium
Valid

Potential Buyer Oracle Fee Loss Due to Validation Timing Misalignment

Summary

A critical timing issue within the validation and purchase phases can lead to buyers losing their oracle fees. If the final validation for an asset occurs after the buy phase has ended, the buyer is unable to complete the purchase, forfeiting any oracle fees paid. This misalignment between validation completion and the purchase deadline creates a scenario where the buyer’s interest is unfulfilled, and their funds are effectively wasted.

Vulnerability Details

Impact

This vulnerability occurs in the timing and coordination between the following components:

The validation process: Final validations must complete before the buy phase concludes.
The purchase() function: Relies on the availability of validated assets within the active buy phase to complete transactions.

Tools Used

Manual Review

Recommendations

Provide buyers with an automatic refund of oracle fees if validations complete after the buy phase, ensuring users do not incur unnecessary losses.

Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Validated
Assigned finding tags:

There is no guarantee that task will be completed and buyerAgent will get a response to its purchaseRequest before the round ends, but that was already paid for

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.