Submission Details
Severity:
Missing check for the asset existence in Swan::getListingPrice()
Description
The existence of the given asset should be checked before returning the price since the default value can be returned and trusted as a correct value.
Recommendations
File: contracts/swan/Swan.sol
function getListingPrice(address _asset) external view returns (uint256) {
-- return listings[_asset].price;
++ AssetListing asset = listings[_asset];
++ require(asset.status != AssetStatus.Unlisted, "Asset unlisted");
++ return asset.price;
}
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420 USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.