Dria

Swan
NFTHardhat
21,000 USDC
View results
Submission Details
Severity: medium
Valid

When owner withdraw feeToken from coordinator, tokens for rewards oracles/validators are not reserved

Summary

When owner call withdrawPlatformFees() in LLMOracleCoordinator.sol, all tokens transfered to owner from contract balance. If owner call this function when there is at least one validator or oracle, who didnt take his reward for his job, they should wait when next user will make request and pay fees. But, what if last user's request was last?

Impact

Oracles/validators should wait next user's request, and only after that, they could take his rewards from coordinator contract. Function withdrawPlatformFees dont reserve tokens for rewards.

Tools Used

Manual review

Recommendations

Add reservation amount in withdrawPlatformFees function.

Updates

Lead Judging Commences

inallhonesty Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`withdrawPlatformFees` withdraws the entire balance

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.