Submission Details
Severity:
DOS caused by large address array when returned using the `Swan::getListedAssets`
Relevant GitHub Links
https://github.com/Cyfrin/2024-10-swan-dria/blob/main/contracts/swan/Swan.sol#L314
Summary
There could be DOS vulnerability due to large array when returned using the Swan::getListedAssets which would make the transaction to revert due to out of gas.
Vulnerability Details
function getListedAssets(address _buyer, uint256 _round) external view returns (address[] memory) {
return assetsPerBuyerRound[_buyer][_round];
}
Impact
DOS because of transaction running out of gas
Tools Used
Manual review
Recommendations
A possible way could be to limit the amount of addresses per time that the Swan::getListedAssets function returns.
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420 USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.