Submission Details
Severity:
ETH Locking on Pending Purchases
Summary
When users face the double-price scenario and do not complete the transaction via resolveTrick(), their paid ETH remains locked in the contract.
Vulnerability Details
Function:
resolveTrick()Code Reference:
mapping(uint256 => uint256) public pendingNFTsAmountPaid;
The pending ETH associated with a partially paid trick is stored in pendingNFTsAmountPaid, but there's no mechanism for users to reclaim this ETH if they abandon the transaction.
Impact
Funds could be permanently locked in the contract, negatively affecting both users and the contract's liquidity.
Tools Used
Manual Code Review
Recommendations
Implement a timeout for users to claim their pending NFTs or refunds:
mapping(uint256 => uint256) public pendingNFTTimestamp; // Store timestamp of pending NFTs
function resolveTrick(uint256 tokenId) public payable nonReentrant {
require(block.timestamp < pendingNFTTimestamp[tokenId] + 7 days, "Pending trick expired");
// Continue with logic...
}
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.