Submission Details
Severity:
Gas Inefficiency in treatNames[] Retrieval
Summary
The getTreats() function returns the entire treatNames[] array, which can become inefficient as the array grows in size.
Vulnerability Details
Function:
getTreats()Code Reference:
function getTreats() public view returns (string[] memory) {
return treatNames;
}
As the number of treats grows, retrieving the entire array in a single call will increase gas usage significantly, making it impractical for users.
Impact
As the list of treats grows, gas costs for this function could become prohibitive, affecting the usability of the contract.
Tools Used
Manual Code Review
Recommendations
Implement pagination for retrieving treat names:
function getTreats(uint256 start, uint256 limit) public view returns (string[] memory) {
uint256 end = start + limit > treatNames.length ? treatNames.length : start + limit;
string[] memory treats = new string[]();
for (uint256 i = start; i < end; i++) {
treats[i - start] = treatNames[i];
}
return treats;
}
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.