Submission Details
Severity:
Missing Event in setTreatCost Function Spookyswap.sol
Summary
The setTreatCost function in SpookySwap contract lacks event emission when updating treat costs, impacting transparency and monitoring capabilities.
Vulnerability Details
function setTreatCost(string memory _treatName, uint256 _cost) public onlyOwner {
require(treatList[_treatName].cost > 0, "Treat must cost something.");
treatList[_treatName].cost = _cost;
}
Impact
Low severity
Reduced transparency for cost changes
Limited off-chain monitoring capabilities
Harder to track historical price changes
Affects dApp integration and user interfaces
Tools Used
Slither
Manuel code review
Recommendations
Benefits of Fix
Enhanced transparency
Better indexing capabilities
Improved monitoring for price changes
Better UX for dApp integrations
Historical price tracking
Add event emission:
event TreatCostUpdated(string treatName, uint256 newCost);
function setTreatCost(string memory _treatName, uint256 _cost) public onlyOwner {
require(treatList[_treatName].cost > 0, "Treat must cost something.");
treatList[_treatName].cost = _cost;
emit TreatCostUpdated(_treatName, _cost);
}
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.