Submission Details
Severity:
The mintTreat function can be affected by reetrancy attack.
Summary
The mintTreat function is vulnerable to reentrancy attacks due to its failure to adhere to the Checks-Effects-Interactions (CEI) pattern.
Vulnerability Details
In the mintTreat function update of the nextTokenId index is after the
_mint(recipient, tokenId);
_setTokenURI(tokenId, treat.metadataURI);
nextTokenId += 1;
emit Swapped(recipient, treat.name, tokenId);
better is to put this part of code before _mint(recipient, tokenId);````_setTokenURI(tokenId, treat.metadataURI);
Impact
Function can be affected by reetrance attack. But it is internaland probability is low.
Tools Used
manual review
Recommendations
Please check Checks-Effects-Interactions (CEI) pattern.
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.