Submission Details
Severity:
Use Constructor for Imports Initialization
Summary
Avoid initializing inherited contracts on the contract line. Instead, handle initialization in the constructor to maintain control and clarity.
Vulnerability Details
The original code initializes Ownable on the contract line using msg.sender, which can lead to unintended behaviors. Moving this initialization to the constructor ensures consistent and clear handling of parameters.
Impact
Low
Tools Used
Manual Review
Recommendation
Move inherited contract initialization to the constructor. For example:
contract SpookySwap is ERC721URIStorage, Ownable, ReentrancyGuard {
constructor(Treat[] memory treats) ERC721("SpookyTreats", "SPKY") Ownable(msg.sender) { }
}
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.