Cannot set the cost if cost is 0
Summary:
Owner cannot call the setTreatCost function, if the cost is 0. But he can add a treat with cost 0.
Vulnerability details:
When the owner wants to call the setTreatCost function and set the cost, he needs to pass the check, but if the price was set to 0 he cannot.
Impact:
cannot set the treat cost.
Tools Used:
Manual review
Recommendations:
The vulnerability occurs, because the owner can add a treat with price of 0. Remove the check in setTreatCost function completely, or add a check to addTreat function, that says the price must be more than 0.
Appeal created
[invalid] Zero treat cost
The cost of the treat is set only by the owner (in the constructor, in addTreat and in setTreatCost). That means the cost of the treat will always be greater than zero.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.