Submission Details
Severity:
No Zero Balance Check in withdrawFees
Summary
The withdrawFees() function doesn't check for a zero balance before attempting to transfer funds.
Vulnerability Details
Location: src/TrickOrTreat.sol:withdrawFees()
Impact
This can lead to unnecessary gas consumption and failed transactions when the contract balance is zero.
Tools Used
Forge
Recommendations
Add a check to ensure the contract balance is greater than zero before initiating the transfer:
function withdrawFees() public onlyOwner {
uint256 balance = address(this).balance;
require(balance > 0, "No balance to withdraw");
payable(owner()).transfer(balance);
emit FeeWithdrawn(owner(), balance);
}
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.