Submission Details
Severity:
Reentrancy in `TrickOrTreat::SpookySwap.withdrawFees` function
Summary : The TrickOrTreat::SpookySwap.withdrawFees function lets the contract owner withdraw funds, but it has a reentrancy vulnerability. This means that if the owner is a contract, it could potentially exploit this function to withdraw more money than intended
Vulnerability Details : When the function transfers the contract's balance to the owner, it doesn’t update the state (like emitting an event) until after the transfer. If the owner's address is a contract, it can re-enter the function before the state changes, allowing it to withdraw additional funds.
Impact : An attacker could drain funds from the contract by repeatedly calling TrickOrTreat::SpookySwap.withdrawFees function, leading to a loss of trust in the contract’s security.
Tools Used : Slither & Manual Review
Recommendations :
function withdrawFees() public onlyOwner {
uint256 balance = address(this).balance;
+ emit FeeWithdrawn(owner(), balance);
payable(owner()).transfer(balance);
- emit FeeWithdrawn(owner(), balance);
}
Rewards breakdown
nSLOC
109This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.