Trick or Treat
First Flight #27
Beginner FriendlyFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

`addTreat` function updates `treatList` mapping if treat already exists but still appends it to `treatNames` array leading to inconsistent treat data.

blaze

addTreat function updates treatList mapping if treat already exists but still appends it to treatNames array leading to inconsistent treat data.

Description:
As treat name is used to get its data, addTreat function should check that only unique names are added. This missing check can lead to treatList mapping getting updated but still new treatName item is pushed if same treat name is added by owner.

Recommended Mitigation:

function addTreat(string memory _name, uint256 _rate, string memory _metadataURI) public onlyOwner {
+ require(bytes(treatList[_name].name).length == 0, "Treat already exists");
treatList[_name] = Treat(_name, _rate, _metadataURI);
Updates

Appeal created

bube Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

[invalid] Duplicate treats

The function `addTreat` is called by the owner. The owner is trusted. There will be no duplicates.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.