Trick or Treat

First Flight #27
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

using low-level-calls `SpookySwap::trickOrTreat`

Summary

while this low-level call is functional, it's generally recommended to use higher-level functions for Ether transfers

if (msg.value > requiredCost) {
uint256 refund = msg.value - requiredCost;
(bool refundSuccess,) = msg.sender.call{value: refund}("");
require(refundSuccess, "Refund failed");
}

Vulnerability Details

The use of low-level calls is error-prone. Low-level calls do not check for code existence or call success.

Impact

Tools Used

Personal Knowledge

Recommendations

Use high-level functions like transfer() or send() when possible for better safety and easier auditing.

Updates

Appeal created

bube Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.