Trick or Treat

Summary

In the protocol the counter of the tokenId is resolved by the custom solution.

This solution based on:

Vulnerability Details

Please note that in the trickOrTreat function, the mintTreat function is used in several places. However, in other parts of the function, such as within the else statement, the code that belongs to the mintTreat function is written out instead of calling the function itself.

The inconsistency in using the mintTreat function in some places while writing out the code in others can introduce bugs and make the contract harder to maintain. It’s crucial to refactor the code to consistently use the mintTreat function for clarity and reliability.

Impact

This breaks the fundamental functionality of the protocol.

Tools Used

manual review

Recommendations

Instead of using a custom solution for the tokenId counter, it is better to use OpenZeppelin's Counter.