Trick or Treat

Summary:

resolveTrickfunction does not reset the treatNames array.

Vulnerability Details:

resolveTrickfunction does not reset the treatNames array. This means, that the array will get bigger and bigger over time, which means calling getTreatsfunction will cost more and more gas. Resulting in a potential Denial of Service.

Impact:

Users will not be able to call the getTreatsfunction.

Tools Used:

Manual review

Recommendations:

In the resolveTrickfunction add a line that will reset the treatNames array.

Or limit the array.