Era

ZKsync
FoundryLayer 2
500,000 USDC
View results
Submission Details
Severity: low
Valid

`isPermanentRollup` setter pre-conditions are not validated in `AdminFacet.forwardedBridgeMint`

Summary

The isPermanentRollup pre-conditions are validated in AdminFacet.makePermanentRollup but not in AdminFacet.forwardedBridgeMint.

Vulnerability Details

The function AdminFacet.makePermanentRollup includes checks to ensure that the isPermanentRollup pre-conditions are met before proceeding. However, these checks are missing in the AdminFacet.forwardedBridgeMint function, which can lead to inconsistent state when AdminFacet.forwardedBridgeMint is executed with invalid input.

Impact

Without validating the isPermanentRollup pre-conditions in AdminFacet.forwardedBridgeMint, the contract may enter an invalid state or exhibit unexpected behavior if executed with invalid input.

Tools Used

Code review.

Recommendations

Add the necessary s.isPermanentRollup pre-condition checks in the AdminFacet.forwardedBridgeMint function to ensure consistency and prevent potential issues.

Updates

Lead Judging Commences

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Validated
Assigned finding tags:

`isPermanentRollup` setter pre-conditions are not validated in `AdminFacet.forwardedBridgeMint`

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.