GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Incorrect Verification Status Check in CharityRegistry::isVerified Function

Summary

The isVerified function incorrectly checks if a charity is registered rather than verified, leading to potential misinformation about a charity's verification status

Vulnerability Details

The function currently returns the registration status (registeredCharities[charity]) instead of the verification status (verifiedCharities[charity]).

Impact

Users may trust unverified charities, leading to potential misuse of funds or support.

Tools Used

Manual Review

Recommendations

Update the function to return verifiedCharities[charity] to accurately reflect the verification status.

function isVerified(address charity) public view returns (bool) {
return verifiedCharities[charity];
}
Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-isVerified-return-registered-charities

Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.