GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Zero address check in registerCharity(), CharityRegistry.sol

Summary

In registerCharity() function there isn't any checks for zero address.

Vulnerability Details

function registerCharity(address charity) public {
registeredCharities[charity] = true;
}

Impact

If a user accidentally register address(0) it could cause unexpected behavior in the contract, and functions that relay on registeredCharities .

Tools Used

Manual Review

Recommendations

Add a require for zero address.

function registerCharity(address charity) public {
require(charity != address(0), "Invalid address");
registeredCharities[charity] = true;
}
Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.