GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

`public` functions not used internally could be marked `external`

Instead of marking a function as public, consider marking it as external if it is not used internally.

6 Found Instances

  • Found in src/CharityRegistry.sol [Line: 13]

    function registerCharity(address charity) public {
  • Found in src/CharityRegistry.sol [Line: 17]

    function verifyCharity(address charity) public {
  • Found in src/CharityRegistry.sol [Line: 23]

    function isVerified(address charity) public view returns (bool) {
  • Found in src/CharityRegistry.sol [Line: 28]

    function changeAdmin(address newAdmin) public {
  • Found in src/GivingThanks.sol [Line: 23]

    function donate(address charity) public payable {
  • Found in src/GivingThanks.sol [Line: 58]

    function updateRegistry(address _registry) public {
Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.