GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

NFT Token URI may not be unique, leading to different NFT tokens having the same URI

Summary

In GivingThanks::_createTokenURI, msg.sender, block.timestamp and msg.value are used to generate the token URI.
However, if the same sender have multiple doner transcations in the same block with the same amout, the minted NFT tokens will have the same URI.

Recommendations

Add tokenCounter as another parameter in GivingThanks::_createTokenURI to generate token URI to avoid token URI collision.

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.