Submission Details
Severity:
Logic error -GivingThanks::constructor doesn't use the correct parameter to set the registration.
Summary
GivingThanks::constructor doesn't use the parameter _registry and instead uses msg.sender
to set the registration CharityRegistry(msg.sender).
Vulnerability Details + Recommendations
// see comments @audit
constructor(address _registry) ERC721("DonationReceipt", "DRC") {
registry = CharityRegistry(msg.sender); // @audit remove this line
// @audit above line should be replaced by the below line
registry = CharityRegistry(_registry); // @use this line
owner = msg.sender;
tokenCounter = 0;
}
Impact
Wrong address is verified as the registered charity.
Tools Used
Foundry test.
Manual review
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.