Submission Details
Severity:
Improper access control in the updateRegistry function
Summary
Anyone can call GivingThanks::updateRegistry function and update the registry, even without admin access.
Vulnerability Details
function updateRegistry(address _registry) public {
registry = CharityRegistry(_registry);
}
POC
function testUpdateRegistry() public {
vm.prank(donor);
charityContract.updateRegistry(newx);
console.log(address(charityContract.registry()));
console.log(newx);
assertEq(address(charityContract.registry()), newx);
}
Impact
Anyone can call this function with any address and update the registry
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-change-registry
Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.