GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

The owner field in GivingThanks contract is not used

Summary

GivingThanks contract declares field address public owner; which is set in the constructor to msg.sender but it is not used.

Impact

Depending on the intent of the authors this can have different impact. At the very least this a waste of gas and brings confusion when trying to understand the logic of the code.
If the authors had the idea to use the field as to restrict some of the functionality of the contract to the owner then this has high impact as the field is not used.

Tools Used

Manual review

Recommendations

Either remove the field if it is not going to be used or use it.

Updates

Lead Judging Commences

n0kto Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Appeal created

nurayko Submitter
12 months ago
n0kto Lead Judge
12 months ago
n0kto Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.