Submission Details
Severity:
No Two-Step Admin Transfer in `CharityRegistry.sol`
Description: Admin transfer happens in a single step, which could lead to permanent loss of admin access if wrong address is provided.
Impact:
Risk of losing admin access through typos
No confirmation from new admin
No way to recover from mistakes
Recommended Mitigation: Implement a two-step transfer pattern like the given below:
address public pendingAdmin;
function initiateAdminTransfer(address newAdmin) public onlyAdmin nonZeroAddress(newAdmin) {
pendingAdmin = newAdmin;
emit AdminTransferInitiated(admin, newAdmin);
}
function acceptAdminTransfer() public {
require(msg.sender == pendingAdmin, "Only pending admin can accept");
admin = pendingAdmin;
pendingAdmin = address(0);
emit AdminTransferCompleted(admin);
}
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.