GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Public Functions not used internally could be marked external

Instead of marking a function as `public`, consider marking it as `external` if it is not used internally.
<details><summary>6 Found Instances</summary>
- Found in src/CharityRegistry.sol
```solidity
function registerCharity(address charity) public {
```
- Found in src/CharityRegistry.sol
```solidity
function verifyCharity(address charity) public {
```
- Found in src/CharityRegistry.sol
```solidity
function isVerified(address charity) public view returns (bool) {
```
- Found in src/CharityRegistry.sol
```solidity
function changeAdmin(address newAdmin) public {
```
- Found in src/GivingThanks.sol
```solidity
function donate(address charity) public payable {
```
- Found in src/GivingThanks.sol
```solidity
function updateRegistry(address _registry) public {
```
</details>
Updates

Lead Judging Commences

n0kto Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.