GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Conformance to Solidity naming conventions

The function doesn't adhere to Solidity's naming conventions, which generally recommend using camelCase (also called "mixedCase") for function parameters. In `function, _registry` it does not follow this convention because of the leading underscore.
```function updateRegistry(address _registry) public {
registry = CharityRegistry(_registry);
}
```
**Mitigation**
Parameter Naming: Changed `_registry` to `registryAddress` to follow camelCase naming.
```function updateRegistry(address registryAddress) public {
require(registryAddress != address(0), "Invalid address");
registry = CharityRegistry(registryAddress);
}
```
Updates

Lead Judging Commences

n0kto Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.