GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Missing owner validation in updateRegistryfunction

Summary

  • Owner check is missing in updateRegistry function allowing unauthorized updates of registry address.

Impact

  • Anyone can update registry to give incorrect verified status due to which charities will not be able to receive donations.

Tools Used

  • Manual review

Recommendations

  • Add onlyOwner check to updateRegistry function.

function updateRegistry(address _registry) public {
+ require(msg.sender == owner, "caller is not owner");
registry = CharityRegistry(_registry);
Updates

Lead Judging Commences

n0kto Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-anyone-can-change-registry

Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.