Submission Details
Severity:
Anyone can update `CharityRegistry` contract
Summary
GivingThanks protocol has ability to update the CharityRegistrycontract, but it should be allowed only for admins, unfortunately it lacks this check.
function updateRegistry(address _registry) public {
registry = CharityRegistry(_registry);
}
Vulnerability Details
Impact
Anyone can change the registry address.
Tools Used
Manual review.
Recommendations
Add check if the caller of the function is admin
function updateRegistry(address _registry) public {
+ require(msg.sender == admin, "...");
registry = CharityRegistry(_registry);
}
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-anyone-can-change-registry
Likelyhood: High, anyone can change it at anytime Impact: High, can bypass the verification process
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.