GivingThanks

First Flight #28
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Valid

Wrong variable check in `isVerified` in CharityRegistry

Summary

isVerifiedis checking registeredCharitiesinstead of verifiedCharitieshere: https://github.com/Cyfrin/2024-11-giving-thanks/blob/main/src/CharityRegistry.sol#L24

function isVerified(address charity) public view returns (bool) {
return registeredCharities[charity];
}

This leads to allowing unverified but registered charities to receive donations.

Recommendations

Use verifiedCharities

function isVerified(address charity) public view returns (bool) {
return verifiedCharities[charity];
}
Updates

Lead Judging Commences

n0kto Lead Judge 12 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-isVerified-return-registered-charities

Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.