Submission Details
Severity:
Wrong variable check in `isVerified` in CharityRegistry
Summary
isVerifiedis checking registeredCharitiesinstead of verifiedCharitieshere: https://github.com/Cyfrin/2024-11-giving-thanks/blob/main/src/CharityRegistry.sol#L24
function isVerified(address charity) public view returns (bool) {
return registeredCharities[charity];
}
This leads to allowing unverified but registered charities to receive donations.
Recommendations
Use verifiedCharities
function isVerified(address charity) public view returns (bool) {
return verifiedCharities[charity];
}
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-isVerified-return-registered-charities
Likelyhood: High, the function returns registered charities instead of verified ones. Impact: High, Any charities can be registered by anyone and will be declared as verified by this function bypassing verification.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.