Submission Details
Severity:
Using `ERC721::_mint` is dangerous
Summary
The contract uses the _mint function to create new ERC721 tokens, which does not check if the recipient is capable of receiving ERC721 tokens.
Line: https://github.com/Cyfrin/2024-11-giving-thanks/blob/main/src/GivingThanks.sol#L26
_mint(msg.sender, tokenCounter);
Impact
-
Potential Token Loss:
If tokens are minted to a contract that does not implement the
onERC721Receivedfunction, they could become permanently locked, leading to loss of tokens.
-
Compliance with ERC721 Standard:
The ERC721 standard recommends using
_safeMintto ensure safe transfers to contracts.
Recommendations
Use _safeMint
_safeMint(msg.sender, tokenCounter);
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.