Submission Details
Severity:
registry variable doesnt incorrect address
Summary
Incorrect code in constructor of CharityRegistry contract
Vulnerability Details
The contract has below incorrect code. msg.sender contains deployer address but not registry address. Due to this registry doesnt store registery address.
registry = CharityRegistry(msg.sender);
Impact
Registry functions wont work in GivingThanks contract
Tools Used
Manual review
Recommendations
Change it to this
registry = CharityRegistry(_registry);
Updates
Lead Judging Commences
n0kto 12 months ago
Submission Judgement Published Assigned finding tags:
finding-bad-registry-set-at-construction
Likelyhood: High, the parameter is not well used and won't be set. Impact: Low, can be changed with the setter and no one will be able to donate to malicious charity.
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.