GivingThanks

Summary:

A deployment conflict occurs due to a mismatch in the expected address for the CharityRegistry contract instance in GivingThanks.sol. This prevents the GivingThanks contract from deploying correctly, as the _registry parameter is not utilized as intended in the constructor.

Vulnerability Details:

In GivingThanks.sol, the constructor receives an address parameter _registry intended to reference an existing CharityRegistry contract instance. However, the _registry address is not correctly utilized in the contract, which results in a failure during deployment. This makes the GivingThanks contract unusable as it cannot be deployed to the blockchain without addressing this issue.

Impact

High Impact: The deployment failure blocks the GivingThanks contract from functioning, preventing any interactions on-chain. This issue effectively halts the contract’s deployment and intended operation.

Tools Used

Tools Used

• Manual code review

• Foundry (for compilation and testing)

forge compile

Compiler Output

Recommendations

To resolve the issue, modify the constructor in GivingThanks.sol to properly utilize the _registry parameter, as shown below:

This change will correctly assign registry to an instance of the CharityRegistry contract, allowing the GivingThankscontract to interact with it as intended.