Submission Details
Severity:
Missing Event in `changeAdmin` Function
Description
The changeAdmin function allows the current admin to change the admin address. However, there is currently no event emitted to log this change. Emitting an event is important for tracking changes to the admin address on the blockchain.
Code Snippet
function changeAdmin(address newAdmin) public {
require(msg.sender == admin, "Only admin can change admin");
admin = newAdmin;
}
Recommendation
Add an event declaration for admin changes and emit this event within the changeAdmin function after successfully changing the admin address. This will provide a clear log of admin changes on the blockchain.
Code Snippet
// Declare the AdminChanged event
event AdminChanged(address indexed oldAdmin, address indexed newAdmin);
function changeAdmin(address newAdmin) public {
require(msg.sender == admin, "Only admin can change admin");
address oldAdmin = admin; // Store the old admin address
admin = newAdmin;
emit AdminChanged(oldAdmin, newAdmin); // Emit the AdminChanged event
}
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.