Submission Details
Severity:
Missing Event in `verifyCharity` Function
Description
The verifyCharity function allows the admin to verify a registered charity by adding its address to the verifiedCharities mapping. However, there is currently no event emitted to log this verification. Emitting an event is crucial for tracking charity verifications on the blockchain.
Code Snippet
function verifyCharity(address charity) public {
require(msg.sender == admin, "Only admin can verify");
require(registeredCharities[charity], "Charity not registered");
verifiedCharities[charity] = true;
}
Recommendation
Add an event declaration for charity verifications and emit this event within the verifyCharity function after successfully verifying the charity. This will provide a clear log of charity verifications on the blockchain.
Code Snippet
// Declare the CharityVerified event
event CharityVerified(address indexed charity);
function verifyCharity(address charity) public {
require(msg.sender == admin, "Only admin can verify");
require(registeredCharities[charity], "Charity not registered");
verifiedCharities[charity] = true;
emit CharityVerified(charity); // Emit the CharityVerified event
}
Rewards breakdown
nSLOC
67This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.